Skip to content

Conversation

@ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Jun 10, 2025

Summary

enable incremental: "advance-slient" by default

tests remain the same, incremental is only tested in rspack-test-tools/tests/Incremental-*.test.js, other tests still test incremental: "safe" (before's behavior)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: feature release: feature related release(mr only) labels Jun 10, 2025
@ahabhgk ahabhgk enabled auto-merge (squash) June 10, 2025 11:28
@netlify
Copy link

netlify bot commented Jun 10, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 6dc3414
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/684816c47389b100086d5c89
😎 Deploy Preview https://deploy-preview-10623--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ahabhgk ahabhgk linked an issue Jun 10, 2025 that may be closed by this pull request
@github-actions

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2025

📝 Ecosystem CI detail: Open

suite result
rspress ✅ success
rslib ❌ failure
modernjs ❌ failure
rsdoctor ❌ failure
rsbuild ✅ success
devserver ❌ failure
nuxt ✅ success
examples ✅ success
plugin ✅ success
lynx-stack ❌ failure

@ahabhgk ahabhgk requested review from JSerFeng and chenjiahan June 10, 2025 11:41
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 10, 2025

CodSpeed Performance Report

Merging #10623 will not alter performance

Comparing enable-inc-by-default (6dc3414) with main (7ab94f5)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 12 untouched benchmarks

@chenjiahan chenjiahan changed the title feat(incremental): enable advance-slient preset by default perf(incremental): enable advance-slient preset by default Jun 10, 2025
@github-actions github-actions bot added release: performance release: performance related release(mr only) and removed release: feature release: feature related release(mr only) labels Jun 10, 2025
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ahabhgk ahabhgk merged commit 8aeb122 into main Jun 10, 2025
56 checks passed
@ahabhgk ahabhgk deleted the enable-inc-by-default branch June 10, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tracking]: affected-based incremental rebuild

2 participants