chore: remove useless incremental config #5409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the now-useless "incremental" configuration from tests and the basic plugin since Rspack 1.4.0-beta.0 enables it by default.
- Removed "incremental": true from snapshot tests
- Removed conditional configuration for Rspack in the basic plugin
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/tests/snapshots/environments.test.ts.snap | Removed "incremental": true from experiments config |
| packages/core/tests/snapshots/default.test.ts.snap | Updated snapshot by removing the "incremental": true entry |
| packages/core/tests/snapshots/builder.test.ts.snap | Removed "incremental": true from the test snapshot |
| packages/core/tests/snapshots/basic.test.ts.snap | Removed "incremental": true from both development and production snapshots |
| packages/core/src/plugins/basic.ts | Removed the conditional logic adding "incremental": true |
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rspack 1.4.0-beta.0 enables
incrementalby default and we can remove theincrementalconfig from Rsbuild.Related Links
Checklist