Skip to content

docs: add performance.removeMomentLocale to upgrade guide#6994

Merged
chenjiahan merged 1 commit intomainfrom
moment_migration_0119
Jan 19, 2026
Merged

docs: add performance.removeMomentLocale to upgrade guide#6994
chenjiahan merged 1 commit intomainfrom
moment_migration_0119

Conversation

@chenjiahan
Copy link
Member

Summary

Added a section in upgrade guide, explaining the removal of the performance.removeMomentLocale option and the reason for its deprecation.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings January 19, 2026 03:39
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's upgrade guide to inform users about the removal of the performance.removeMomentLocale configuration option. This change reflects an underlying improvement in Rspack v2, where Moment.js locales are no longer bundled by default, thus eliminating the need for a specific option to remove them. The update ensures that users migrating from v1 to v2 are aware of this change and its implications.

Highlights

  • Documentation Update: Added a new section to the upgrade guide (v1 to v2) in both English and Chinese, detailing the removal of the performance.removeMomentLocale option.
  • Option Deprecation Rationale: The documentation clarifies that performance.removeMomentLocale is no longer necessary because Rspack v2 does not include Moment.js locale data by default, rendering the option obsolete.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@netlify
Copy link

netlify bot commented Jan 19, 2026

Deploy Preview for rsbuild-v2 ready!

Name Link
🔨 Latest commit a2daae1
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild-v2/deploys/696da7866600e50008533cef
😎 Deploy Preview https://deploy-preview-6994--rsbuild-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for the removal of the performance.removeMomentLocale option in the v1 to v2 upgrade guide for both English and Chinese. The changes are clear and accurate. My only suggestion is to reorder the new sections to maintain alphabetical order within the performance options group for better discoverability.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds documentation for the removal of the performance.removeMomentLocale configuration option in Rsbuild v2. The option is no longer necessary since Rspack v2 does not bundle Moment.js locale files by default.

Changes:

  • Added a new section to the v1-to-v2 upgrade guide explaining the removal of performance.removeMomentLocale
  • Included the rationale: Rspack v2 no longer includes Moment locales by default, making the optimization option obsolete
  • Referenced the related PR #6991 for additional context

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
website/docs/en/guide/upgrade/v1-to-v2.mdx Added English documentation section explaining the removal of performance.removeMomentLocale
website/docs/zh/guide/upgrade/v1-to-v2.mdx Added Chinese documentation section explaining the removal of performance.removeMomentLocale

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan merged commit be10dd0 into main Jan 19, 2026
16 checks passed
@chenjiahan chenjiahan deleted the moment_migration_0119 branch January 19, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant