feat!: remove performance.removeMomentLocale option#6991
Conversation
✅ Deploy Preview for rsbuild-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the build configuration by removing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly removes the performance.removeMomentLocale option, which has become obsolete due to changes in Rspack v2. The removal is comprehensive, touching upon plugin logic, configuration, types, tests, dependencies, and documentation in both English and Chinese. The changes are clean and well-executed. This is a good simplification of the codebase. Before merging, please ensure the checklist in the pull request description is completed.
There was a problem hiding this comment.
Pull request overview
This pull request removes the deprecated performance.removeMomentLocale configuration option from Rsbuild. The removal is justified because Rspack v2 no longer bundles moment.js locales by default, making this optimization unnecessary.
Changes:
- Removed the
performance.removeMomentLocaleconfiguration option and its implementation - Removed documentation for the removed feature in both English and Chinese
- Removed moment.js as a development dependency
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/zh/guide/start/features.mdx | Removed "优化 moment.js 体积" row from the performance features table |
| website/docs/zh/config/performance/remove-moment-locale.mdx | Deleted Chinese documentation for the removed configuration option |
| website/docs/en/guide/start/features.mdx | Removed "Optimize moment.js size" row from the performance features table |
| website/docs/en/config/performance/remove-moment-locale.mdx | Deleted English documentation for the removed configuration option |
| packages/core/src/types/config.ts | Removed removeMomentLocale property from PerformanceConfig interface |
| packages/core/src/defaultConfig.ts | Removed default value for removeMomentLocale |
| packages/core/src/plugins/moment.ts | Deleted the entire moment plugin implementation |
| packages/core/src/createRsbuild.ts | Removed import and registration of pluginMoment |
| packages/core/tests/snapshots/environments.test.ts.snap | Updated snapshots to remove removeMomentLocale: false from normalized configs |
| e2e/package.json | Removed moment.js from dependencies |
| e2e/cases/performance/moment-locale/src/index.js | Deleted test source file |
| e2e/cases/performance/moment-locale/index.test.ts | Deleted test file for moment locale feature |
| pnpm-lock.yaml | Removed moment.js package entries |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Summary
The
performance.removeMomentLocaleoption has been removed. This is because Rspack v2 no longer bundles moment.js locales by default, so the optimization is unnecessary and has no effect.Related Links
See web-infra-dev/rspack#12697
Checklist