Skip to content

refactor(server): simplify error page by removing headers handling #6413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Oct 23, 2025
Merged

refactor(server): simplify error page by removing headers handling #6413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 2 additions & 30 deletions packages/core/src/server/assets-middleware/middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,17 +99,9 @@ const parseRangeHeaders = (value: string): RangeResult | Ranges => {
});
};

type SendErrorOptions = {
headers?: Record<string, number | string | string[] | undefined>;
};

const acceptedMethods = ['GET', 'HEAD'];

function sendError(
res: ServerResponse,
code: HttpCode,
options?: Partial<SendErrorOptions>,
): void {
function sendError(res: ServerResponse, code: HttpCode): void {
const errorMessages: Record<HttpCode, string> = {
[HttpCode.BadRequest]: 'Bad Request',
[HttpCode.Forbidden]: 'Forbidden',
Expand Down Expand Up @@ -137,22 +129,6 @@ function sendError(
'utf-8',
);

const headers = res.getHeaderNames();
for (let i = 0; i < headers.length; i++) {
res.removeHeader(headers[i]);
}

if (options?.headers) {
const keys = Object.keys(options.headers);
for (let i = 0; i < keys.length; i++) {
const key = keys[i];
const value = options.headers[key];
if (typeof value !== 'undefined') {
res.setHeader(key, value);
}
}
}

res.statusCode = code;
res.setHeader('Content-Type', 'text/html; charset=utf-8');
res.setHeader('X-Content-Type-Options', 'nosniff');
Expand Down Expand Up @@ -428,11 +404,7 @@ export function createMiddleware(
getValueContentRangeHeader('bytes', size),
);

sendError(res, HttpCode.RangeNotSatisfiable, {
headers: {
'Content-Range': res.getHeader('Content-Range'),
},
});
sendError(res, HttpCode.RangeNotSatisfiable);
return;
}
if (parsedRanges === -2) {
Expand Down
Loading