refactor(server): simplify error page by removing headers handling#6413
Merged
chenjiahan merged 1 commit intomainfrom Oct 23, 2025
Merged
refactor(server): simplify error page by removing headers handling#6413chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies error handling in the assets middleware by removing unnecessary header manipulation logic. The change eliminates the ability to clear existing response headers and set custom headers when sending error pages, as this provided no security benefit since clients accessing error pages can also view normal dev server responses.
Key changes:
- Removed
SendErrorOptionstype and optional headers parameter fromsendErrorfunction - Eliminated logic that cleared all existing response headers before sending error pages
- Simplified the call to
sendErrorfor range-not-satisfiable errors
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR removes the logic that clears all existing response headers before sending an error page. The previous implementation provided no real security benefit, since clients that can access the error page can also access normal dev server responses and view the same headers.
Checklist