fix(core): normalize paths for include/exclude rules on Windows#6380
Merged
chenjiahan merged 2 commits intomainfrom Oct 18, 2025
Merged
fix(core): normalize paths for include/exclude rules on Windows#6380chenjiahan merged 2 commits intomainfrom
chenjiahan merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes path normalization issues on Windows when using source.include rules with require.resolve, which returns paths with forward slashes that may not match the expected format for path matching.
Key Changes:
- Adds an end-to-end test to verify that
source.includeworks correctly with paths obtained fromrequire.resolve - The test creates a mock dependency and ensures it's properly included and processed through the build pipeline
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
e2e/cases/source/source-include-dependency/src/index.js |
Adds test source file that imports from the mock 'test' package |
e2e/cases/source/source-include-dependency/rsbuild.config.ts |
Configures the test with source.include using dirname(require.resolve()) pattern |
e2e/cases/source/source-include-dependency/index.test.ts |
Implements the e2e test that verifies syntax checking works on included dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
On Windows,
require.resolvereturns paths with forward slashes (when usingjiti) which can cause issues withsource.includerules. This change adds path normalization to ensure consistent path handling across platforms.Related Links
resolve #6372
Checklist