refactor(server): improve publicDir normalization#6360
Merged
chenjiahan merged 3 commits intomainfrom Oct 15, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the server configuration to centralize publicDir normalization during the config normalization phase, eliminating redundant calls throughout the codebase. The changes improve code maintainability by ensuring publicDir is normalized once and available as a required field in NormalizedServerConfig.
- Move publicDir normalization to the config normalization phase
- Update type definitions to reflect normalized publicDir as a required field
- Remove redundant normalization calls from server files
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/types/config.ts | Update NormalizedServerConfig to include required normalized publicDir field |
| packages/core/src/defaultConfig.ts | Move publicDir normalization to config structure phase and make function private |
| packages/core/src/server/watchFiles.ts | Remove redundant normalization and use normalized publicDir directly |
| packages/core/src/server/devMiddlewares.ts | Remove redundant normalization and use normalized publicDir directly |
| packages/core/src/plugins/server.ts | Remove redundant normalization and use normalized publicDir directly |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
NormalizedServerConfigtype definitions to reflect required publicDir fieldChecklist