Skip to content

perf: lazy import node crypto #5383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Jun 8, 2025
Merged

perf: lazy import node crypto #5383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/src/helpers/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import crypto from 'node:crypto';
import { posix } from 'node:path';
import { URL } from 'node:url';
import deepmerge from 'deepmerge';
Expand Down Expand Up @@ -366,7 +365,8 @@ export const addCompilationError = (
);
};

export function hash(data: string): string {
export async function hash(data: string): Promise<string> {
const crypto = await import('node:crypto');
// Available in Node.js v20.12.0
// faster than `crypto.createHash()` when hashing a smaller amount of data (<= 5MB)
if (crypto.hash) {
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/plugins/cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ export const pluginCache = (): RsbuildPlugin => ({

// set cache name to avoid cache conflicts between different environments
const cacheVersion = useDigest
? `${environment.name}-${env}-${hash(JSON.stringify(cacheConfig.cacheDigest))}`
? `${environment.name}-${env}-${await hash(JSON.stringify(cacheConfig.cacheDigest))}`
: `${environment.name}-${env}`;

if (bundlerType === 'rspack') {
Expand Down
Loading