Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Switch from synchronous to asynchronous imports of the Node crypto module by converting the hash helper to return a Promise and updating its callsite in pluginCache.
hashfunction now uses a dynamicimport('node:crypto')and returns aPromise<string>- Updated cache plugin to
await hash(...)when building the cache version string
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/helpers/index.ts | Made hash async with lazy import of node:crypto and updated signature |
| packages/core/src/plugins/cache.ts | Added await before hash(...) to accommodate the async return |
Comments suppressed due to low confidence (3)
packages/core/src/helpers/index.ts:368
- Consider adding a JSDoc comment to explain that this function now returns a Promise and uses a dynamic import of
node:crypto.
export async function hash(data: string): Promise<string> {
packages/core/src/helpers/index.ts:368
- The signature change from synchronous to async requires updating or adding tests that
await hash(...)to ensure consistent behavior.
export async function hash(data: string): Promise<string> {
packages/core/src/plugins/cache.ts:152
- Ensure that the enclosing function or callback is declared
async, otherwise usingawaithere will cause a syntax error.
? `${environment.name}-${env}-${await hash(JSON.stringify(cacheConfig.cacheDigest))}`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Switching from sync to async imports of the
cryptomodule. Additionally, it updates thehashfunction to return aPromiseand adjusts its usage accordingly.Checklist