Skip to content

fix: avoid colon in output config file name #5325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 2 commits into from
May 28, 2025
Merged

fix: avoid colon in output config file name #5325

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bb212c
fix: avoid colon in output config file name
9aoy May 28, 2025
f4bc936
fix: update
9aoy May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/core/src/inspectConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ export async function outputInspectConfigFiles({
}): Promise<void> {
const { outputPath } = inspectOptions;

const formatOutputName = (name: string) => name.replace(/[:]/g, '_');

const files = [
...rawEnvironmentConfigs.map(({ name, content }) => {
if (rawEnvironmentConfigs.length === 1) {
Expand All @@ -113,7 +115,7 @@ export async function outputInspectConfigFiles({
content,
};
}
const outputFile = `rsbuild.config.${name}.mjs`;
const outputFile = `rsbuild.config.${formatOutputName(name)}.mjs`;
const outputFilePath = join(outputPath, outputFile);

return {
Expand All @@ -123,7 +125,7 @@ export async function outputInspectConfigFiles({
};
}),
...rawBundlerConfigs.map(({ name, content }) => {
const outputFile = `${configType}.config.${name}.mjs`;
const outputFile = `${configType}.config.${formatOutputName(name)}.mjs`;
let outputFilePath = join(outputPath, outputFile);

// if filename is conflict, add a random id to the filename.
Expand Down
Loading