fix: avoid colon in output config file name #5325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue with colons in output configuration file names by replacing them with underscores.
- Added a helper function (escapeOutputName) to sanitize file names by replacing colons.
- Updated file name construction for both environment and bundler configuration files.
packages/core/src/inspectConfig.ts
Outdated
| }): Promise<void> { | ||
| const { outputPath } = inspectOptions; | ||
|
|
||
| const escapeOutputName = (name: string) => name.replace(/[:]/g, '_'); |
There was a problem hiding this comment.
[nitpick] Consider adding a doc comment for the escapeOutputName function to clarify its purpose and the rationale behind replacing colons with underscores.
chenjiahan
approved these changes
May 28, 2025
This was referenced May 28, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
avoid colon in output config file name.
Related Links
Checklist