Skip to content

fix(cache): buildCache.cacheDirectory config not work #4790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 5 commits into from
Mar 14, 2025
Merged

fix(cache): buildCache.cacheDirectory config not work #4790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e728855
fix(plugins):fixed the cache path configuration
Shucei Mar 14, 2025
5f3cf9d
Merge branch 'main' into shucei
Shucei Mar 14, 2025
5eecb65
fix(core):fixed the cache path configuration
Shucei Mar 14, 2025
08c2efc
Merge branch 'shucei' of https://github.com/Shucei/rsbuild into shucei
Shucei Mar 14, 2025
1109663
test: update cache test snapshots
Shucei Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/core/src/plugins/cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,10 @@ export const pluginCache = (): RsbuildPlugin => ({
cache: {
type: 'persistent',
version: cacheVersion,
directory: cacheDirectory,
storage: {
type: 'filesystem',
directory: cacheDirectory,
},
buildDependencies: Object.values(buildDependencies).flat(),
},
});
Expand Down
25 changes: 20 additions & 5 deletions packages/core/tests/__snapshots__/cache.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@ exports[`plugin-cache > 'should add cache config correctly' 1`] = `
"buildDependencies": [
"<ROOT>/packages/core/tests/tsconfig.json",
],
"directory": "<ROOT>/packages/core/tests/node_modules/.cache/rspack",
"storage": {
"directory": "<ROOT>/packages/core/tests/node_modules/.cache/rspack",
"type": "filesystem",
},
"type": "persistent",
"version": "web-test",
},
Expand All @@ -29,7 +32,10 @@ exports[`plugin-cache > 'should apply cacheDigest' 1`] = `
"buildDependencies": [
"<ROOT>/packages/core/tests/tsconfig.json",
],
"directory": "<ROOT>/packages/core/tests/node_modules/.cache/rspack",
"storage": {
"directory": "<ROOT>/packages/core/tests/node_modules/.cache/rspack",
"type": "filesystem",
},
"type": "persistent",
"version": "web-test-c29a5747",
},
Expand All @@ -50,7 +56,10 @@ exports[`plugin-cache > 'should custom cache directory by user' 1`] = `
"buildDependencies": [
"<ROOT>/packages/core/tests/tsconfig.json",
],
"directory": "<ROOT>/packages/core/tests/node_modules/.cache/tmp",
"storage": {
"directory": "<ROOT>/packages/core/tests/node_modules/.cache/tmp",
"type": "filesystem",
},
"type": "persistent",
"version": "web-test",
},
Expand Down Expand Up @@ -81,7 +90,10 @@ exports[`plugin-cache > 'should not apply cacheDigest' 1`] = `
"buildDependencies": [
"<ROOT>/packages/core/tests/tsconfig.json",
],
"directory": "<ROOT>/packages/core/tests/node_modules/.cache/rspack",
"storage": {
"directory": "<ROOT>/packages/core/tests/node_modules/.cache/rspack",
"type": "filesystem",
},
"type": "persistent",
"version": "web-test",
},
Expand All @@ -102,7 +114,10 @@ exports[`plugin-cache > 'should watch tsconfig change' 1`] = `
"buildDependencies": [
"<ROOT>/packages/core/tests/tsconfig.json",
],
"directory": "<ROOT>/packages/core/tests/node_modules/.cache/rspack",
"storage": {
"directory": "<ROOT>/packages/core/tests/node_modules/.cache/rspack",
"type": "filesystem",
},
"type": "persistent",
"version": "web-test",
},
Expand Down
Loading