fix(cache): buildCache.cacheDirectory config not work#4790
Merged
chenjiahan merged 5 commits intoweb-infra-dev:mainfrom Mar 14, 2025
Merged
fix(cache): buildCache.cacheDirectory config not work#4790chenjiahan merged 5 commits intoweb-infra-dev:mainfrom
buildCache.cacheDirectory config not work#4790chenjiahan merged 5 commits intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
buildCache. cacheDirectory config not work
buildCache. cacheDirectory config not workbuildCache.cacheDirectory config not work
chenjiahan
approved these changes
Mar 14, 2025
This was referenced Mar 14, 2025
Merged
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fix: Rspack cache directory config not taking effect due to incorrect config structure
When configuring
performance.buildCache.cacheDirectoryin Rsbuild, the cache directory setting was not being applied correctly for Rspack. This is because Rspack requires the cache directory to be configured underexperiments.cache.storage.directory, while the current implementation was placing it directly underexperiments.cache.directory.Before: