Refactoring getFileLocation to be static CMakeBuilder method #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng regex to find path Signed-off-by: amitrahman1026 <[email protected]>
lingyuncai
reviewed
Nov 9, 2023
There was a problem hiding this comment.
Hi @amitrahman1026, thanks for the contribution!
The refactor part LGTM.
For the regex in getFileLocation, another example is as below and we could want a scan starting from the last line to get CMakeLists.txt from CMakeLists.txt:15 (find_package), which doesn't have the CMake Error at prefix.
CMake Error at /usr/share/test.cmake:137 (message):
Some message here.
Call Stack (most recent call first):
/usr/share/test.cmake:378 (FAILURE_MESSAGE)
cmake/another_test.cmake:71 (find_package_handle_standard_args)
CMakeLists.txt:15 (find_package)
|
Addressing multi-line block detection (#34) by adding detection for closing comment 
|
lingyuncai
reviewed
Nov 9, 2023
Signed-off-by: amitrahman1026 <[email protected]>
lingyuncai
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #35
Updated regex in getFileLocation as well
Tested out some scenarios, but edge case of filename containing ":" still exist, maybe I could get some help with that 😅