Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move getFileLocation function to CMakeBuilder class #35

Closed
lingyuncai opened this issue Nov 7, 2023 · 3 comments
Closed

Move getFileLocation function to CMakeBuilder class #35

lingyuncai opened this issue Nov 7, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@lingyuncai
Copy link
Contributor

lingyuncai commented Nov 7, 2023 •
edited
Loading

Currently, the getFileLocation function is used by CMakeBuilder only and the logic was implemented for cmake errors logs as well. We should probably move it to the CMakeBuilder class, and implement separate methods for other builders if needed in the future.
@lingyuncai lingyuncai added the good first issue Good for newcomers label Nov 7, 2023
@sinapy
Copy link

sinapy commented Nov 7, 2023

could you give some examples for testing? @lingyuncai

@lingyuncai lingyuncai changed the title Fix the RegExp for file name detection with spaces Move getFileLocation function to CMakeBuilder class Nov 7, 2023
@lingyuncai
Copy link
Contributor Author

Hi @sinapy, I changed this issue slightly as this is more suitable for good first issue. If you are still interested, please feel free to submit a PR :)

@amitrahman1026 amitrahman1026 mentioned this issue Nov 9, 2023
Merged
@lingyuncai
Copy link
Contributor Author

Close as fixed in #39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sinapy @lingyuncai