Parse and evaluate calc expressions #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewilligers
force-pushed
the
process-calc-expression
branch
from
ee288bd to
65721b0
Compare
Contributor
|
Nice! Though unfortunately this fails one of the calc unit tests. |
We no longer rely on 'eval'. Instead, we parse the calc expression and compute the value. We take advantage of the requirement that + and - operators must be surrounded by whitespace. This lets us detect each of the five tokens in -1.23e+45 + -1.23e+45 - -1.23e+45 using a simple regular expression. Spec: https://www.w3.org/TR/css3-values/#calc-syntax resolves web-animations#74
ewilligers
force-pushed
the
process-calc-expression
branch
from
65721b0 to
a081deb
Compare
Contributor
Author
That is a new unit test that uses scientific notation. I have updated typeCheck's regular expression to allow scientific notation. |
Contributor
|
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer rely on 'eval'. Instead, we parse the calc expression
and compute the value.
We take advantage of the requirement that + and - operators must
be surrounded by whitespace. This lets us detect each of the five tokens
in -1.23e+45 + -1.23e+45 - -1.23e+45 using a simple regular expression.
Spec:
https://www.w3.org/TR/css3-values/#calc-syntax
This adds 449 bytes to web-animations-next-lite.min.js
resolves #74