Remove eval #105
Closed
Remove eval #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of isFinite. This allows the polyfill to run strict mode.
Contributor
|
I'm afraid removing eval() without regressing functionality isn't so easy. parseDimension() can handle arbitrary calc() expressions, see test case: https://github.com/web-animations/web-animations-js/blob/dev/test/js/dimension-handler.js#L19 |
|
Are there any work arounds to move forward with this without regressing? It would be great to add our CSP policy back to forbid eval. |
Contributor
|
I intend to implement this soon.
…On 18 Mar 2017 8:54 am, "Jason Nelson" ***@***.***> wrote:
Are there any work arounds to move forward with this without regressing?
It would be great to add our CSP policy back to forbid eval.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#105 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA4ttpD4Fz3E_6lhVCalmL7ORQdpDEC1ks5rmwEegaJpZM4LzYkE>
.
|
Contributor
|
Eval replacement is up for review in #151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove eval in favour of type conversion, then check for isNaN instead of isFinite. This allows the polyfill to run strict mode.