Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple smaller fixes #895

Merged
merged 5 commits into from
Feb 21, 2024
Merged

Couple smaller fixes #895

merged 5 commits into from
Feb 21, 2024

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Feb 20, 2024 •
edited
Loading

Closes #882

couple smaller things:

  • missing docstring for nested objects
  • remove unneeded groupby object definition
  • openai generative tests did not work anymore
  • added all object-types (single return, general obejct, GroupBy object, Generative Object) to output type
  • better error message in case the GRPC health check fails

@dirkkul dirkkul force-pushed the add_missing_return_type branch from 19222bc to 96466aa Compare February 21, 2024 05:11
@dirkkul dirkkul changed the title Add return type for query.objects Couple smaller fixes Feb 21, 2024
@dirkkul dirkkul merged commit 74411eb into main Feb 21, 2024
35 checks passed
@dirkkul dirkkul deleted the add_missing_return_type branch February 21, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmith023 tsmith023 tsmith023 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reconsider your definition of private and public interface please
2 participants
@dirkkul @tsmith023