-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconsider your definition of private and public interface please #882
Comments
H, all types should be available as TypeAlias in |
Well at least to some degree. But this doesn't really solve everything. For example I can't really find a public type for object from |
Ah, this one is missing from the |
Okay thanks for clarification. I didn't know about the |
@dirkkul When will this be released ? 👉👈 |
End of this week probably |
When trying to use this client in your own code with type hints, you are facing the challenge of adding typehints for specific return objects. For example
collection.query.fetch_objects()
has a private return type ofQueryReturn
which only exists inweaviate.collections.classes.internals
. So you are exposing your private interface via your public interface, which doesn't make sense.Hope it's understandable.
Cheers 🍺
The text was updated successfully, but these errors were encountered: