Skip to content

tracing: Allow specifying JAEGER_ENDPOINT instead of sampling server or local agent port #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2020
Merged

tracing: Allow specifying JAEGER_ENDPOINT instead of sampling server or local agent port #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tracing/tracing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (

// ErrInvalidConfiguration is an error to notify client to provide valid trace report agent or config server
var (
ErrBlankTraceConfiguration = errors.New("no trace report agent or config server specified")
ErrBlankTraceConfiguration = errors.New("no trace report agent, config server, or collector endpoint specified")
)

// installJaeger registers Jaeger as the OpenTracing implementation.
Expand All @@ -35,7 +35,7 @@ func NewFromEnv(serviceName string) (io.Closer, error) {
return nil, errors.Wrap(err, "could not load jaeger tracer configuration")
}

if cfg.Sampler.SamplingServerURL == "" && cfg.Reporter.LocalAgentHostPort == "" {
if cfg.Sampler.SamplingServerURL == "" && cfg.Reporter.LocalAgentHostPort == "" && cfg.Reporter.CollectorEndpoint == "" {
return nil, ErrBlankTraceConfiguration
}

Expand Down