Skip to content

Conversation

chancez
Copy link
Contributor

@chancez chancez commented Nov 5, 2020

closes #203

Copy link
Contributor

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, I noticed this behavior, but never tracked down why it occurred. Good fix.

@bboreham can you review when you get a chance?

Copy link
Collaborator

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bboreham bboreham merged commit 47e357f into weaveworks:master Dec 1, 2020
@chancez chancez deleted the jaeger_collector_http branch December 1, 2020 19:09
@bboreham
Copy link
Collaborator

bboreham commented Dec 9, 2020

Ideally this PR should have updated the comment on lines 29-31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better handle configuring jaeger tracing with thrift http transport

3 participants