Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remaining accessibility fixes #552

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Remaining accessibility fixes #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions web/themes/new_weather_theme/templates/block/block--weathergov-daily-forecast.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,29 +37,27 @@ set classes = [
<div class="display-flex flex-column flex-align-center">
{# TODO: we will need to provide translation for this alt text #}
<span class="usa-sr-only">
day will be high of "{{ data.daytime.temperature }}" degrees
day will be high of "{{ data.daytime.temperature }}" degrees Fahrenheit
</span>
<div class="display-flex flex-row">
<span class="font-body-xl position-relative">
<span class="font-body-xl position-relative" aria-hidden="true">
{{ data.daytime.temperature }}
<span class="font-body-3xs position-absolute display-inline-block left-full margin-top-05">&#x2109;</span>
<span class="font-body-3xs position-absolute display-inline-block left-full margin-top-05">℉</span>
</span>
{# use HTML entity that reads "degree farenheit" to screen readers #}
</div>
<div class="display-flex flex-row">
{# TODO: we will need to provide translation for this alt text #}
<span class="usa-sr-only">
night will be low of "{{ data.overnight.temperature }}" degrees
night will be low of "{{ data.overnight.temperature }}" degrees Fahrenheit
</span>
<span class="position-relative font-body-lg text-gray-50">
<span class="position-relative font-body-lg text-gray-50" aria-hidden="true">
<div class="font-body-3xs position-absolute margin-left-neg-105">
<svg aria-hidden="true" role="img" style="width:9px;height:9px;">
<use xlink:href="{{ "/" ~ directory ~ '/assets/images/spritesheet.svg#overnight' }}"></use>
</svg>
</div>
{{ data.overnight.temperature }}
<div class="font-body-3xs display-inline-block position-absolute left-full">&#x2109</div>
{# use HTML entity that reads "degree farenheit" to screen readers #}
<div class="font-body-3xs display-inline-block position-absolute left-full">℉</div>
</span>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions web/themes/new_weather_theme/templates/navigation/menu--footer.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<nav class="usa-identifier__section usa-identifier__section--required-links" aria-label="{{ 'Important links' | t }}">
<nav class="usa-identifier__section usa-identifier__section--required-links">
<div class="usa-identifier__container padding-0">
<ul class="usa-identifier__required-links-list">
{% for item in items %}
Expand All @@ -10,4 +10,4 @@
{% endfor %}
</ul>
</div>
</nav>
</nav>
Loading