Remaining accessibility fixes

[eric-gade]

What does this PR do? 🛠️

This PR deals with two remaining accessibility concerns highlighted in #516 :

• Footer` links are grouped in multiple elements with aria labels?
• Daily forecast: Repetition temperature reads “day will be high of “54” degrees 54º night will be low of 48ºF”

What does the reviewer need to know? 🤔

You will want to use VoiceOver to test the following:

• That the links in the footer are labelled only as "footer primary links"
• That the daily forecast temperature text items are read as a complete sentence, and that the individual number and degrees texts are not read (separately) at all

[eric-gade]

@greg-does-weather One question I'm not sure about: because of our templates, we currently have the site links in the footer wrapped in two nested <nav> elements that appear to be dealing with the same thing. The first (inner one) is here. The second (outer one) is here.

I'm thinking we might want to ditch the inner <nav> and simply have the template it appears in display the unordered list.

[greg-does-weather]

I love the way the daily forecast reads. 🤩

To your question, I'm happy to follow your lead on HTML layout. If we didn't lift our footer straight from a USWDS template, we might want to do that but honestly, I still get lost sometimes with the right ways to nest semantic elements.

[greg-does-weather]

Code Review Checklist

A checked item is either an assertion that I have tested this item or an indication that I have verified it does not apply to this pull request.

The Basics

• Checks are passing
• I read the code
• I ran the code
• (if applicable) Post deploy steps are run
• (if applicable) I validated the change on the deployed version in

Accessibility

• New pages have been added to cypress-axe file so that they will be tested with our automated accessibility testing
• Meets WCAG 2.0 AA or 2.1 AA for Section 508 compliance
  • Site is keyboard accessible. All interactions can be accessed with a keyboard
  • Site is free of keyboard traps. The keyboard focus is never trapped in a loop
  • All form inputs have explicit labels
  • Form instructions are associated with inputs
  • All relevant images use an img tag
  • All images have appropriate alt attributes
  • Multimedia is tagged. All multimedia has appropriate captioning and audio description
  • Text has sufficient color contrast. All text has a contrast ratio of 4.5:1 with the background
  • Site never loses focus. Focus is always visible when moving through the page with the keyboard
  • Tab order is logical
  • Tables are coded properly. Tables have proper headers and column attributes
  • Headings are nested properly. Heading elements are nested in a logical way
  • Language is set. The language for the page is set
  • CSS is not required to use the page. The page makes sense with or without CSS
  • Links are unique and contextual. All links can be understood taken alone, e.g., ‘Read more - about 508’
  • Page titles are descriptive

Device Matrix

• firefox/gecko (renders correctly and user interactions work)
• chrome/chromium/edge (renders correctly and user interactions work)
• safari/webkit (renders correctly and user interactions work)
• web page is readable and usable
  • at 480px (mobile)
  • at 640px (tablet)
  • at 1024px (desktop)