Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select default WFO correctly, regardless of capitalization of WFO in path #1657

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Select default WFO correctly, regardless of capitalization of WFO in path #1657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44086f5
default selected value correctly
greg-does-weather Aug 28, 2024
14b4507
Merge branch 'main' into mgwalker/1653-afd-wfo-select
greg-does-weather Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions tests/playwright/e2e/afd-page.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,19 @@ describe("AFD Page Tests", () => {
await page.goto("http://localhost:8080/afd/OKX");
});

describe("WFO selector correctly populates based on path", () => {
test("with uppercase WFO code", async ({ page }) => {
const selected = page.locator("wx-afd-selector #wfo-selector");
await expect(selected).toHaveValue("OKX");
});

test("with lowercase WFO code", async ({ page }) => {
await page.goto("http://localhost:8080/afd/okx");
const selected = page.locator("wx-afd-selector #wfo-selector");
await expect(selected).toHaveValue("OKX");
});
});

test("Selecting third version and clicking button will load that version", async ({page}) => {
const thirdId = OKX_REFERENCES["@graph"][2].id;
const versionSelect = await page.locator('select#version-selector');
Expand Down
2 changes: 2 additions & 0 deletions web/themes/new_weather_theme/templates/layout/afd-page.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
{% set wfo = wfo | upper %}

<div class="layout-container grid-row height-full flex-column flex-no-wrap">
<header role="banner">
<div class="grid-container">
Expand Down
Loading