Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select default WFO correctly, regardless of capitalization of WFO in path #1657

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Select default WFO correctly, regardless of capitalization of WFO in path #1657

merged 2 commits into from
Aug 29, 2024

Conversation

greg-does-weather
Copy link
Collaborator

What does this PR do? 🛠️

Uppercases the WFO before building the list of form <option> elements.

jamestranovich-noaa
jamestranovich-noaa approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@jamestranovich-noaa jamestranovich-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greg-does-weather greg-does-weather merged commit ba57fd5 into main Aug 29, 2024
16 of 17 checks passed
@greg-does-weather greg-does-weather deleted the mgwalker/1653-afd-wfo-select branch August 29, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamestranovich-noaa jamestranovich-noaa jamestranovich-noaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When visiting an AFD page using a lowercase WFO code, the WFO select is not populated correctly
2 participants
@greg-does-weather @jamestranovich-noaa