Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wx prefix to custom classes #1315

Merged
merged 18 commits into from
Jun 13, 2024
Merged

Add wx prefix to custom classes #1315

merged 18 commits into from
Jun 13, 2024

Conversation

partly-igor
Copy link
Collaborator

@partly-igor partly-igor commented Jun 12, 2024

What does this PR do? 🛠️

This PR adds a wx prefix to the custom utility classes and components we use. It add to the work started in #1313 and
together with that PR closes #1247

What does the reviewer need to know? 🤔

Two notes:

  1. This PR is on top of Reorganize SASS files and classes #1313 and should be reviewed/merged second (or alternatively just review this one, though there are more files changed so the diffs for the prefix addition might be longer)
  2. Seeing in in practice here, it's a good moment to re-evaluate if we do want to go ahead with this approach of using the prefix for all custom classes.

Copy link
Collaborator

@greg-does-weather greg-does-weather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I made some suggested edits related to PHP test names, but it's not breaking or blocking either way.

@partly-igor
Copy link
Collaborator Author

Thanks for catching those

@partly-igor partly-igor merged commit a5f08f1 into main Jun 13, 2024
14 checks passed
@partly-igor partly-igor deleted the ik/wx-rename branch June 13, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organize CSS files
2 participants