-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wx prefix to custom classes #1315
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partly-igor
requested review from
eric-gade,
greg-does-weather and
loganmcdonald-noaa
June 12, 2024 17:15
greg-does-weather
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I made some suggested edits related to PHP test names, but it's not breaking or blocking either way.
web/modules/weather_blocks/src/Plugin/Block/Test/DailyForecastBlock.php.test
Outdated
Show resolved
Hide resolved
web/modules/weather_blocks/src/Plugin/Block/Test/DailyForecastBlock.php.test
Outdated
Show resolved
Hide resolved
web/modules/weather_blocks/src/Plugin/Block/Test/HourlyForecastBlock.php.test
Outdated
Show resolved
Hide resolved
web/modules/weather_blocks/src/Plugin/Block/Test/HourlyForecastBlock.php.test
Outdated
Show resolved
Hide resolved
Thanks for catching those |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? 🛠️
This PR adds a
wx
prefix to the custom utility classes and components we use. It add to the work started in #1313 andtogether with that PR closes #1247
What does the reviewer need to know? 🤔
Two notes: