Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize SASS files and classes #1313

Merged
merged 8 commits into from
Jun 12, 2024
Merged

Reorganize SASS files and classes #1313

merged 8 commits into from
Jun 12, 2024

Conversation

partly-igor
Copy link
Collaborator

@partly-igor partly-igor commented Jun 11, 2024

What does this PR do? 🛠️

This PR reorganizes some of our sass files, putting component specific classes into their own sass file partial. This is 1 of 2 PRs for #1247. The second PR will add the wx prefix to our custom utilities and components.

What does the reviewer need to know? 🤔

There should be no visual difference before and after this PR

PR
Screenshot of current tab for the PR

Screenshot of 7 days tab for the PR

Beta
Screenshot of current tab on the beta site

Screenshot of 7 days tab on the beta site

Copy link
Contributor

This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file?

Copy link
Collaborator

@greg-does-weather greg-does-weather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@partly-igor partly-igor merged commit be602c5 into main Jun 12, 2024
14 checks passed
@partly-igor partly-igor deleted the ik/organize-sass branch June 12, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants