Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting of milestone skills #9

Closed
wduda opened this issue Apr 13, 2017 · 6 comments · Fixed by #31 or #29
Closed

Fix sorting of milestone skills #9

wduda opened this issue Apr 13, 2017 · 6 comments · Fixed by #31 or #29
Assignees
Labels
Milestone

Comments

@wduda
Copy link
Owner

wduda commented Apr 13, 2017

Well here is part of the issue and it's a game issue - and a workaround:

When you open your Skills panel and go to Milestone Skills, the order they are listed in-game is messed up and is as follows:

Current
7
8
9
10
11
2
3
4
5
6

If you open the Travel Window Options and go to Sort, and set up the order in this way, then open Travel Window using Mode: Icon Grid, some of the icons don't match the numbers in the Options | Sort panel.

To make the icons match the order shown in the game's Milestone Skills list (which is whack), sort your skills in the Options | Sort window as follows:

Current
10
9
8
7
11
2
3
4
5
6

@wduda wduda added the bug label Dec 16, 2020
@djhenderson
Copy link

I came here to report the same problem. It is very annoying when you have more than 6 but not all of the higher milestone skills.

@Dromo
Copy link
Contributor

Dromo commented Dec 17, 2020

According to this forum post; the order of the milestone skills in game depends on the order of purchase.

@djhenderson
Copy link

I carefully purchased the milestone skills in numeric order (not the order of listing in the store), and I have all my e-receipts from Xsolla to confirm this, When I purchased Milestone Skill VII, it did not appear when I checked milestone skill 7 in the Travel plugin. IIRC, it showed up when I checked milestone 10 in the plugin.

I expect that the skills listed when you attempt to bind to a milestone is sorted in GID order. (The GID is the Global ID, the internal code used to identify the milestone skill.)

@wduda
Copy link
Owner Author

wduda commented Dec 23, 2020

I am looking into finding or creating a way to have a unique identifier for skills, so maybe there is a way to fix this problem in Travel Window II at least. Since Milestone skills have a unique ID I might be able to use that.

@wduda wduda self-assigned this Jan 7, 2021
@wduda wduda added this to the v1.0.7beta milestone Jan 7, 2021
@wduda wduda linked a pull request Jan 7, 2021 that will close this issue
@wduda
Copy link
Owner Author

wduda commented Jan 7, 2021

The issue was that the plugin was mixing up the pairs of skill name and skill ID. I.e. "Return Home 7" had the saved ID of "Return Home 10". Will be fixed with 1.0.7beta release.

@wduda
Copy link
Owner Author

wduda commented Jan 7, 2021

I have used the sort order in the tooltip, where it says seventh, eighth, ninth etc skill.

@wduda wduda mentioned this issue Jan 7, 2021
@wduda wduda linked a pull request Jan 7, 2021 that will close this issue
@wduda wduda closed this as completed Jan 7, 2021
wduda pushed a commit that referenced this issue Oct 4, 2024
# This is the 1st commit message:

Update SkillData.lua

Add strings for RU localization.
Some cosmetic changes in code.
# This is the commit message #2:

fixing unecessary reformat

# This is the commit message #3:

fixing different type of unneccessary reformat

# This is the commit message #4:

fixing more formatting

# This is the commit message #5:

more formatting fixes

# This is the commit message #6:

last round of formatting fixes

# This is the commit message #7:

Update LocaleStrings.lua

RU translation
Fix some typos

# This is the commit message #8:

fixing typo in language string

# This is the commit message #9:

fixup locale names, by fixing typos and missing names

# This is the commit message #10:

Update SkillData.lua

Add strings for RU localization.
Some cosmetic changes in code.

# This is the commit message #11:

fixing unecessary reformat

# This is the commit message #12:

fixing different type of unneccessary reformat

# This is the commit message #13:

fixing more formatting

# This is the commit message #14:

fixed formatting

# This is the commit message #15:

updated formatting

# This is the commit message #16:

fixed spacing
wduda pushed a commit that referenced this issue Oct 4, 2024
# This is the 1st commit message:

Update SkillData.lua

Add strings for RU localization.
Some cosmetic changes in code.
# This is the commit message #2:

fixing unecessary reformat

# This is the commit message #3:

fixing different type of unneccessary reformat

# This is the commit message #4:

fixing more formatting

# This is the commit message #5:

more formatting fixes

# This is the commit message #6:

last round of formatting fixes

# This is the commit message #7:

Update LocaleStrings.lua

RU translation
Fix some typos

# This is the commit message #8:

fixing typo in language string

# This is the commit message #9:

fixup locale names, by fixing typos and missing names

# This is the commit message #10:

Update SkillData.lua

Add strings for RU localization.
Some cosmetic changes in code.

# This is the commit message #11:

fixing unecessary reformat

# This is the commit message #12:

fixing different type of unneccessary reformat

# This is the commit message #13:

fixing more formatting

# This is the commit message #14:

fixed formatting

# This is the commit message #15:

updated formatting

# This is the commit message #16:

fixed spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants