Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting does not work and is not saved #15

Closed
wduda opened this issue Dec 16, 2020 · 5 comments · Fixed by #29
Closed

Sorting does not work and is not saved #15

wduda opened this issue Dec 16, 2020 · 5 comments · Fixed by #29
Assignees
Labels
Milestone

Comments

@wduda
Copy link
Owner

wduda commented Dec 16, 2020

No description provided.

@wduda wduda self-assigned this Dec 16, 2020
@wduda wduda added the bug label Dec 16, 2020
@wduda wduda modified the milestone: 1.1.0stable Dec 16, 2020
@wduda
Copy link
Owner Author

wduda commented Jan 4, 2021

3- The "Return to Camp" skill always sorts to the end of the list even though I have it set to the top of the list in Travel Options->Sort. If I close the Travel Options window and then reopen it, some random travel skill appears at the top of the sort list and "Return to Camp" is back where it was before I moved it (near the bottom).

@wduda
Copy link
Owner Author

wduda commented Jan 4, 2021

4- If I attempt to sort "Ost Guruth (Rep)" to a higher position on the list, it moves to the new position on the list but the icon position does not change in the skill display window. If I then close and reopen the "Travel Options" window, "Ost Guruth (Rep)" appears in the lower location from which I had previously moved it rather than where I placed it.

@wduda
Copy link
Owner Author

wduda commented Jan 4, 2021

he does not remember the order of the icons as I set them
--

@wduda
Copy link
Owner Author

wduda commented Jan 4, 2021

Forochel seems to be missing as well (I made sure it was checked) but whenever I try to sort one travel skill, a random one will move (Aka Whenever I move misty mountains, it moves Snowbourn instead).

@Dromo
Copy link
Contributor

Dromo commented Jan 5, 2021

Im not sure how it is for others, but this is only issue for me after first load. First time loading - sorting skills does nothing. Reload plugin sort gets reset but sorting works and saves for reloads later fine, with some exceptions.

Trying to move Ost Guruth (Rep) did nothing and broke the sort again - moving other skills stopped working too and had to reload again.

Moving Return to Camp moved the item below it instead (Return to Thorins Hall (Guide))

Can confirm, Forochel (Suri-Kyla) Guide is missing from the travel window. I have the skill and have it set in the selected tab, also can move it in the sort window, but it is not actually displayed in the main plugin window.

@wduda wduda modified the milestones: v1.0.8beta, v1.0.7beta Jan 6, 2021
@wduda wduda mentioned this issue Jan 7, 2021
@wduda wduda linked a pull request Jan 7, 2021 that will close this issue
@wduda wduda closed this as completed Jan 7, 2021
wduda pushed a commit that referenced this issue Oct 4, 2024
# This is the 1st commit message:

Update SkillData.lua

Add strings for RU localization.
Some cosmetic changes in code.
# This is the commit message #2:

fixing unecessary reformat

# This is the commit message #3:

fixing different type of unneccessary reformat

# This is the commit message #4:

fixing more formatting

# This is the commit message #5:

more formatting fixes

# This is the commit message #6:

last round of formatting fixes

# This is the commit message #7:

Update LocaleStrings.lua

RU translation
Fix some typos

# This is the commit message #8:

fixing typo in language string

# This is the commit message #9:

fixup locale names, by fixing typos and missing names

# This is the commit message #10:

Update SkillData.lua

Add strings for RU localization.
Some cosmetic changes in code.

# This is the commit message #11:

fixing unecessary reformat

# This is the commit message #12:

fixing different type of unneccessary reformat

# This is the commit message #13:

fixing more formatting

# This is the commit message #14:

fixed formatting

# This is the commit message #15:

updated formatting

# This is the commit message #16:

fixed spacing
wduda pushed a commit that referenced this issue Oct 4, 2024
# This is the 1st commit message:

Update SkillData.lua

Add strings for RU localization.
Some cosmetic changes in code.
# This is the commit message #2:

fixing unecessary reformat

# This is the commit message #3:

fixing different type of unneccessary reformat

# This is the commit message #4:

fixing more formatting

# This is the commit message #5:

more formatting fixes

# This is the commit message #6:

last round of formatting fixes

# This is the commit message #7:

Update LocaleStrings.lua

RU translation
Fix some typos

# This is the commit message #8:

fixing typo in language string

# This is the commit message #9:

fixup locale names, by fixing typos and missing names

# This is the commit message #10:

Update SkillData.lua

Add strings for RU localization.
Some cosmetic changes in code.

# This is the commit message #11:

fixing unecessary reformat

# This is the commit message #12:

fixing different type of unneccessary reformat

# This is the commit message #13:

fixing more formatting

# This is the commit message #14:

fixed formatting

# This is the commit message #15:

updated formatting

# This is the commit message #16:

fixed spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants