Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.2.0: german client, skill not detected: Rückkehr zur Taverne 'Zum Blutigen Adler' #161

Closed
AlterTobi opened this issue Jan 5, 2024 · 5 comments
Closed

v1.2.0: german client, skill not detected: Rückkehr zur Taverne 'Zum Blutigen Adler' #161

AlterTobi opened this issue Jan 5, 2024 · 5 comments
Assignees
@wduda
Labels
bug verified Bug report verified
Milestone
v1.3.0

Comments

@AlterTobi
Copy link

I've bought the rep skill, but the plugin (current git version as of today 05.01.2024) does not detect the skill.

[01/05 11:44:13 PM] Nicht erlernte Fertigkeit: Rückkehr zur Taverne 'Zum Blutigen Adler'

image
@whiterabbit963
Copy link
Collaborator

@AlterTobi Please see whiterabbit963/TravelWindowII:tavern_debug
Please post the output when the plugin is loaded. I expect to see

DOES THIS LOOK RIGHT: Rückkehr zur Taverne \qZum Blutigen Adler\q

@AlterTobi
Copy link
Author

output is

DOES THIS LOOK RIGHT: Rückkehr zur Taverne "Zum Blutigen Adler"

And something about warden, but I logged in with my champ.

Warden coords 0x7004D73A not in dictionary
Warden dictionary coords 0x7004d73a not configured

@whiterabbit963
Copy link
Collaborator

whiterabbit963 commented Jan 6, 2024 •
edited
Loading

output is

DOES THIS LOOK RIGHT: Rückkehr zur Taverne "Zum Blutigen Adler"

Cool. That makes sense why it failed. They must translate /q to a double quote.

Warden coords 0x7004D73A not in dictionary
Warden dictionary coords 0x7004d73a not configured

Good find! Fortunately, there is nothing to worry about. On second thought, an incorrect id could break any legitimate matching. Definitely a potential bug. I added some coord verification based on skill ids for debugging. The skill is present in the maps if you logon to your warden, but it did not occur to me the id would be case sensitive. Easy update.

Thanks for troubleshooting! I'll work on some fixes for those issues.

Update: Alright, I pushed the fixes to tavern_debug. Please make sure the 'Rückkehr zur Taverne "Zum Blutigen Adler"' skill recognized by TWII now.
I will leave that branch for you and rebase those fixes earlier to be included with the other language file updates.

@AlterTobi
Copy link
Author

Looks good.

I've seen, you also changed the hunter and warden skills. Unfortunatly I can't tell you something about those since I don't own high level chars of those classes.

@whiterabbit963
Copy link
Collaborator

whiterabbit963 commented Jan 7, 2024 •
edited
Loading

Unfortunately, neither do I. However, the localization in the dat files was composed the same. I am thinking it is safe to assume they will also be quoted and match in-game in the same way.

whiterabbit963 added a commit to whiterabbit963/TravelWindowII that referenced this issue Jan 7, 2024
@whiterabbit963
fix single quote issue in "Zum Blutigen Adler" for DE (wduda#161)
4fca1c4 
Updated reputation, warden, and hunter skill names.
The raw value in the game files shows the double quote as an escaped
letter q, eg. '\q'. These are the only places I have observed this
behavior.
@wduda wduda self-assigned this Jan 7, 2024
@wduda wduda moved this from Triage to In Progress in Travel Window II Jan 7, 2024
@wduda wduda added this to the v1.2.1 milestone Jan 7, 2024
wduda added a commit that referenced this issue Jan 7, 2024
@wduda
fix #161
c8431f8
@wduda wduda moved this from In Progress to Done in Travel Window II Jan 7, 2024
@wduda wduda modified the milestones: v1.2.1, v1.3.0 Jan 7, 2024
@wduda wduda added bug verified Bug report verified labels Jan 7, 2024
@wduda wduda closed this as completed Jan 7, 2024
wduda added a commit that referenced this issue Jan 7, 2024
@wduda @whiterabbit963
Integrating performance fixes (#162)
6d220f1 
* adding fixes for duplicate name (#149)

* fixes #135 in EN

* Handle racial/rep duplicate names

* fix typo in debug string

---------

Co-authored-by: whiterabbit963 <[email protected]>

* fixes #145 in EN

(cherry picked from commit 7c11fb8)

* fixes #145 in FR

(cherry picked from commit f5d2a71)

* fixes #145 in DE

(cherry picked from commit fde4be5)

* metadata for v1.2.0

(cherry picked from commit 1f12547)

* updated v1.2.0 metadata again

* Update integration branch (#158)

* preparing release v1.2.0 (#150)

* adding fixes for duplicate name (#149)

* fixes #135 in EN

* Handle racial/rep duplicate names

* fix typo in debug string

---------

Co-authored-by: whiterabbit963 <[email protected]>

* fixes #145 in EN

(cherry picked from commit 7c11fb8)

* fixes #145 in FR

(cherry picked from commit f5d2a71)

* fixes #145 in DE

(cherry picked from commit fde4be5)

* metadata for v1.2.0

(cherry picked from commit 1f12547)

* updated v1.2.0 metadata again

* Update assign_project.yml to start working again

* Update assign_project.yml

* Update assign_project.yml

* Update assign_project.yml

* Update assign_project.yml

* Delete .github/workflows/assign_project.yml

* store all skills in the dictionary based on the label

* add missing descriptions for Dol Amroth class skills for EN

* add some skill descriptions in DE

* fix single quote issue in "Zum Blutigen Adler" for DE (#161)

Updated reputation, warden, and hunter skill names.
The raw value in the game files shows the double quote as an escaped
letter q, eg. '\q'. These are the only places I have observed this
behavior.

* fix typo in warden skill id for DE

* add missing descriptions in FR

Removed duplicate/copy/paste mariner locations

* add visual skill scanner

New skills must be visually inspected, and this will help speed up the
process for finding new skills as they are added.

* specify ShortcutType instead of using raw int

* replace raw Action value with UI_Toggle enumeration

* hide options window on escape and ui_toggle

* remove excess spacing

* remove custom resize logic

* add TravelListTab:SetSize() overload

* handle starting size and position when creating settings for the first time

* save width/height on a resize to Settings

* when the settingsmenu item is selected, set the min opacity

* set min window opacity when opening from toggle button

* Performance Improvements (#142)

This was done by skipping the FindSkill() operation, which searches
every trained skill (hundreds). Since the trained skills list is
never updated, it is completely unnecessary to repeat the search.
If skills are updated, it would be necessary to reacquire this list
and perform a single additional search.
Added a found cache value to TravelShortcut.
Add a CheckSkills() call when opening the window.
Until auto-detection scanning is completed this should suffice.

* fixup and improve options panel performance

In SetMapHome() remove call to SetShortcuts().
This method should rarely be called because it is effectively
an init method using static data.

* improve layout and resizing for pulldown tab

* improve combobox resizing

* improve consistency with setting the opacity on a hover leave

* fixup and enforce minimum window sizes

* only resize and save dimensions for list & grid tabs

* remove unused default init settings for carousel quickslots

* allow right-click menu to show up when clicking around the window edges

* pulldown list updates

fixup initialization of pulldown tab
auto select the first item in the pulldown list
added more cases to auto-close the pulldown

* allow window to go behind other windows

Normalizes expected behavior.

* startup window with min opacity setting

* fixup various alpha values for backcolors

* remove unnecesary zorder, opacity, and visibility settings

Without this, the shortcut cannot be clicked or tooltip viewed.

* set min opacity when travel window is under a window on leave

Opening the right-click context menu will set min opacity now,
but in retrospect this seems fine.

* optimize bubble sort

* fix #161

* improved comments in dictionary

* adding 1.3.0 metadata

---------

Co-authored-by: whiterabbit963 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wduda wduda

Labels
bug verified Bug report verified
Projects
Travel Window II
Archived in project
Milestone
v1.3.0
Development

No branches or pull requests
3 participants
@wduda @whiterabbit963 @AlterTobi