Renamed Umbar travel skills + new Bloody Eagle Tavern port #145
Assignees
Labels
Comments
wduda
changed the title
wduda
added a commit
that referenced
this issue
Dec 31, 2023
wduda
added a commit
that referenced
this issue
Dec 31, 2023
* adding fixes for duplicate name (#149) * fixes #135 in EN * Handle racial/rep duplicate names * fix typo in debug string --------- Co-authored-by: whiterabbit963 <[email protected]> * fixes #145 in EN (cherry picked from commit 7c11fb8) * fixes #145 in FR (cherry picked from commit f5d2a71) * fixes #145 in DE (cherry picked from commit fde4be5) * metadata for v1.2.0 (cherry picked from commit 1f12547) * updated v1.2.0 metadata again
wduda
added a commit
that referenced
this issue
Dec 31, 2023
* preparing release v1.2.0 (#150) * adding fixes for duplicate name (#149) * fixes #135 in EN * Handle racial/rep duplicate names * fix typo in debug string --------- Co-authored-by: whiterabbit963 <[email protected]> * fixes #145 in EN (cherry picked from commit 7c11fb8) * fixes #145 in FR (cherry picked from commit f5d2a71) * fixes #145 in DE (cherry picked from commit fde4be5) * metadata for v1.2.0 (cherry picked from commit 1f12547) * updated v1.2.0 metadata again * Update assign_project.yml to start working again * Update assign_project.yml * Update assign_project.yml * Update assign_project.yml * Update assign_project.yml * Delete .github/workflows/assign_project.yml
wduda
added a commit
that referenced
this issue
Jan 7, 2024
* adding fixes for duplicate name (#149) * fixes #135 in EN * Handle racial/rep duplicate names * fix typo in debug string --------- Co-authored-by: whiterabbit963 <[email protected]> * fixes #145 in EN (cherry picked from commit 7c11fb8) * fixes #145 in FR (cherry picked from commit f5d2a71) * fixes #145 in DE (cherry picked from commit fde4be5) * metadata for v1.2.0 (cherry picked from commit 1f12547) * updated v1.2.0 metadata again * Update integration branch (#158) * preparing release v1.2.0 (#150) * adding fixes for duplicate name (#149) * fixes #135 in EN * Handle racial/rep duplicate names * fix typo in debug string --------- Co-authored-by: whiterabbit963 <[email protected]> * fixes #145 in EN (cherry picked from commit 7c11fb8) * fixes #145 in FR (cherry picked from commit f5d2a71) * fixes #145 in DE (cherry picked from commit fde4be5) * metadata for v1.2.0 (cherry picked from commit 1f12547) * updated v1.2.0 metadata again * Update assign_project.yml to start working again * Update assign_project.yml * Update assign_project.yml * Update assign_project.yml * Update assign_project.yml * Delete .github/workflows/assign_project.yml * store all skills in the dictionary based on the label * add missing descriptions for Dol Amroth class skills for EN * add some skill descriptions in DE * fix single quote issue in "Zum Blutigen Adler" for DE (#161) Updated reputation, warden, and hunter skill names. The raw value in the game files shows the double quote as an escaped letter q, eg. '\q'. These are the only places I have observed this behavior. * fix typo in warden skill id for DE * add missing descriptions in FR Removed duplicate/copy/paste mariner locations * add visual skill scanner New skills must be visually inspected, and this will help speed up the process for finding new skills as they are added. * specify ShortcutType instead of using raw int * replace raw Action value with UI_Toggle enumeration * hide options window on escape and ui_toggle * remove excess spacing * remove custom resize logic * add TravelListTab:SetSize() overload * handle starting size and position when creating settings for the first time * save width/height on a resize to Settings * when the settingsmenu item is selected, set the min opacity * set min window opacity when opening from toggle button * Performance Improvements (#142) This was done by skipping the FindSkill() operation, which searches every trained skill (hundreds). Since the trained skills list is never updated, it is completely unnecessary to repeat the search. If skills are updated, it would be necessary to reacquire this list and perform a single additional search. Added a found cache value to TravelShortcut. Add a CheckSkills() call when opening the window. Until auto-detection scanning is completed this should suffice. * fixup and improve options panel performance In SetMapHome() remove call to SetShortcuts(). This method should rarely be called because it is effectively an init method using static data. * improve layout and resizing for pulldown tab * improve combobox resizing * improve consistency with setting the opacity on a hover leave * fixup and enforce minimum window sizes * only resize and save dimensions for list & grid tabs * remove unused default init settings for carousel quickslots * allow right-click menu to show up when clicking around the window edges * pulldown list updates fixup initialization of pulldown tab auto select the first item in the pulldown list added more cases to auto-close the pulldown * allow window to go behind other windows Normalizes expected behavior. * startup window with min opacity setting * fixup various alpha values for backcolors * remove unnecesary zorder, opacity, and visibility settings Without this, the shortcut cannot be clicked or tooltip viewed. * set min opacity when travel window is under a window on leave Opening the right-click context menu will set min opacity now, but in retrospect this seems fine. * optimize bubble sort * fix #161 * improved comments in dictionary * adding 1.3.0 metadata --------- Co-authored-by: whiterabbit963 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The next skills need to be changed in IndexedDictionaryEn.lua in order to work
Return to the order of the Eagle and Return to the Ledger-Keepers
repLocations:AddSkill("Journey to the Order of the Eagle", "0x700686FE", "Order of the Eagle (Rep)");
repLocations:AddSkill("Journey to the Ledger-keepers", "0x70068704", "Ledger-Keepers (Rep)");
another skill needs to be added :
Return to the Bloody Eagle Tavern or
The text was updated successfully, but these errors were encountered: