Revert #287: self-merged in error#299
Merged
janhilgard merged 1 commit intowaybarrios:mainfrom Apr 15, 2026
Merged
Conversation
)" This reverts commit 2cce3da.
janhilgard
approved these changes
Apr 15, 2026
Collaborator
janhilgard
left a comment
janhilgard
left a comment
There was a problem hiding this comment.
LGTM. Clean revert of the self-merged PR #287.
The PR description is transparent about the process mistake. The test file being removed (test_tokenizer_utils.py) contains valid tests that should indeed be re-merged after proper review by a different contributor.
Only question: will the tests be re-submitted as a new PR? Might be worth linking to it in the description when that happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the test-only PR #287 which was merged by the author in error. The tests are correct and should be re-merged by a different contributor after review.
Apologies for the noise — this was a process mistake, not a code issue.