test: add tokenizer fallback regression coverage#287
Merged
Thump604 merged 1 commit intowaybarrios:mainfrom Apr 14, 2026
Merged
test: add tokenizer fallback regression coverage#287Thump604 merged 1 commit intowaybarrios:mainfrom
Thump604 merged 1 commit intowaybarrios:mainfrom
Conversation
Thump604
added a commit
to Thump604/vllm-mlx
that referenced
this pull request
Apr 14, 2026
)" This reverts commit 2cce3da.
janhilgard
pushed a commit
that referenced
this pull request
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current
mainalready contains theload_model_with_fallback()return fix, so this replacement PR keeps only the regression coverage from #215.Changes:
(model, tokenizer)return pathmlx_lmand the model-detection helpers directlyValidation:
PYTHONPATH=/Users/David/code/vllm-mlx-pr215-regression /opt/ai-runtime/venv-live/bin/python -m pytest /Users/David/code/vllm-mlx-pr215-regression/tests/test_tokenizer_utils.py -qPYTHONPATH=/Users/David/code/vllm-mlx-pr215-regression /opt/ai-runtime/venv-live/bin/python -m py_compile /Users/David/code/vllm-mlx-pr215-regression/tests/test_tokenizer_utils.pyPYTHONPATH=/Users/David/code/vllm-mlx-pr215-regression /opt/ai-runtime/venv-live/bin/python -m black --check --fast /Users/David/code/vllm-mlx-pr215-regression/tests/test_tokenizer_utils.pySupersedes the remaining regression-test portion of #215.