responses: normalize developer and instructions for Codex#219
Closed
krystophny wants to merge 6 commits intowaybarrios:mainfrom
Closed
responses: normalize developer and instructions for Codex#219krystophny wants to merge 6 commits intowaybarrios:mainfrom
krystophny wants to merge 6 commits intowaybarrios:mainfrom
Conversation
dd838de to
64f0bbe
Compare
Contributor
Author
|
Closing this in favor of #214. The prompt-normalization change is now folded into the core Responses PR so reviewers can reason about the request-translation layer in one place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
developercontent into a single leadingsystemmessageinstructionswith developer/system content in the prompt shape Codex expectsMain files
vllm_mlx/server.pytests/test_responses_api.pyStack note
This PR is logically on top of PR #214 because it only makes sense once
/v1/responsesexists.Until #214 lands, GitHub will show the combined diff from the stacked branch. After #214, the remaining diff should be the prompt-normalization change only.
Reviewer focus
The main behavior change is prompt shaping for strict chat templates and Codex-style requests:
developerbecomessysteminstructionsand explicit developer/system content are merged into one leading system messageTests
PYTHONPATH=/Users/ert/code/vllm-mlx /Users/ert/code/.venv/bin/python -m pytest tests/test_responses_api.py -q