Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
load_model_with_fallback()so successfulmlx_lm.load()calls return the(model, tokenizer)tuple instead of falling through asNoneWhy this is independently deployable
Related context
This bug sits beneath several other Apple Silicon model-serving paths.
Relevant surrounding work in
waybarrios/vllm-mlx:#127merged broader Qwen3.5 text support and streaming fixes: Add Qwen3.5 model support (text-only) and fix reasoning+tool streaming waybarrios/vllm-mlx#127#144,#160,#165,#183, and#194: fix: handle 3D KV tensors in prefix cache for Qwen3.5 models waybarrios/vllm-mlx#144 fix: pass size to ArraysCache in BatchMambaCache for Qwen3.5 hybrid models waybarrios/vllm-mlx#160 fix: MLLM continuous batching for hybrid models waybarrios/vllm-mlx#165 fix: compatibility with mlx-lm 0.31.x (prompt_checkpoints tuple) waybarrios/vllm-mlx#183 fix: unpack prompt_checkpoints in _chunked_next for mlx-lm >= 0.31.0 waybarrios/vllm-mlx#194krystophny/vllm-mlx#6: Fix Qwen3.5 hybrid paged cache reconstruction #6This PR deliberately stays below all of that and only fixes the successful return path.
Validation
PYTHONPATH=/Users/ert/code/vllm-mlx /Users/ert/code/.venv/bin/python -m pytest tests/test_tokenizer_utils.py -qpython3 -m compileall vllm_mlxWhat could still improve