Add dynamic_text background colour change

[fayzull0h]

Updated dynamic_text.py to have functionality that sets conditions for the data. Based on the conditions, the background colour will change.

---

This change is 

[BluCodeGH]

Looks good, just a couple nits and merge conflicts to fix.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @fayzull0h)

---

sinks/dashboard/items/dynamic_text.py line 19 at r1 (raw file):

        
        self.condition_count = 0
        self.default_color = '#008000'

Default background color should be a light grey like it currently is.

---

sinks/dashboard/items/dynamic_text.py line 73 at r1 (raw file):

        # If there are conditions, change colour based on them
        #   else, set background to the default color
        if self.condition_count > 0:

You can get rid of this if statement with for/else: https://book.pythontips.com/en/latest/for_-_else.html

---

sinks/dashboard/items/dynamic_text.py line 78 at r1 (raw file):

                if self.condition_true(condition_reference):
                    background_color = condition_reference.childs[2].value().name()
                    self.setStyleSheet('background: ' + background_color)

Does this interfere with the timeout logic that sets the stylesheet to control the text color? Or will it just go back to the default background color on timeout?

[itslinotlie]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @fayzull0h)

---

sinks/dashboard/items/dynamic_text.py line 3 at r1 (raw file):

from pyqtgraph.Qt.QtWidgets import QHBoxLayout, QLabel
from pyqtgraph.Qt.QtCore import QTimer
import pyqtgraph.Qt.QtCore as qtcore

For the sake of consistency, the standard that's been used throughout the repo has been

from pyqtgraph.Qt.QtCore import Qt
...
self.setAttribute(Qt.WidgetAttribute.WA_StyledBackground, True)

[fayzull0h]

Does this interfere with the timeout logic that sets the stylesheet to control the text color? Or will it just go back to the default background color on timeout?

I've fixed all the other issues you mentioned. However, I'm not sure what you mean by this one. Could we go over it in more detail on a call or on Slack?

[KavinSatheeskumar]

Reviewable status: 0 of 1 files reviewed, 5 unresolved discussions (waiting on @BluCodeGH and @fayzull0h)

---

sinks/dashboard/items/dynamic_text.py line 87 at r2 (raw file):

        comparison = condition.childs[0].value()
        condition_value = condition.childs[1].value()
        data = float(self.widget.text())

If the text is a CAN message or something, this causes a stream of errors.

However, all of these comparisons work on strings, so just don't case to float 👍

The only one that really matters for strings is ==, which works the way it should for strings so I say just not casting is the best solution.