Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omnibus Launcher #141

Merged
merged 86 commits into from
Oct 24, 2023
Merged

Omnibus Launcher #141

merged 86 commits into from
Oct 24, 2023

Conversation

Darth-Raazi
Copy link
Contributor

@Darth-Raazi Darth-Raazi commented Sep 30, 2023

NOTE: This has been tested on macOS, Linux and Windows

Currently, launching Omnibus is a pain. The core library plus any sources and sinks all need to be started from separate terminals.

New launcher process:

  • Parse sources and sinks folders to get the current ones
  • List options to user and ask for one source and one sink
  • In the background, start core library, selected source and selected sink
  • On dashboard close, CTRL+C or a fatal error, kill all started process
  • Dump output and error (if exists) from each opened process to terminal

This is an initial launcher design, more features coming in future PRs (log files, multiple source/sink selection, etc.)


This change is Reviewable

Darth-Raazi and others added 30 commits December 29, 2022 23:46
now we listen to all can messages (acts as our interrupt function) and then check if the specified peiod has changed, in which case, send the can message.
@Darth-Raazi Darth-Raazi self-assigned this Sep 30, 2023
@Darth-Raazi Darth-Raazi linked an issue Sep 30, 2023 that may be closed by this pull request
Copy link
Member

@BluCodeGH BluCodeGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work on Linux.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Andre-The-Greek and @KavinSatheeskumar)

@Darth-Raazi Darth-Raazi changed the base branch from wdr to master October 20, 2023 02:57
Copy link
Contributor

@Angeraa Angeraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on windows.

@Darth-Raazi Darth-Raazi merged commit c922213 into master Oct 24, 2023
1 of 2 checks passed
@Darth-Raazi Darth-Raazi deleted the starting_omnibus branch October 24, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Omnibus Launcher
10 participants