capi: Access to ExecutionContext members #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #799 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 88 88
Lines 13182 13182
=======================================
Hits 13086 13086
Misses 96 96
Flags with carried forward coverage won't be shown. Click here to find out more. |
gumb0
force-pushed
the
capi-exec-context
branch
3 times, most recently
from
5942b59
to
dbb2526
Compare
axic
reviewed
Jun 2, 2021
gumb0
commented
Jun 3, 2021
|
|
||
| void fizzy_free_execution_context(FizzyExecutionContext* ctx) FIZZY_NOEXCEPT; | ||
|
|
||
| int* fizzy_get_execution_context_depth(FizzyExecutionContext* ctx) FIZZY_NOEXCEPT; |
There was a problem hiding this comment.
Does this returning int* look fine, or would _get/_set functions be better?
There was a problem hiding this comment.
Not sure, need to try in Rust how to interact with that, but we could merge this as a first step anyway.
gumb0
force-pushed
the
capi-exec-context
branch
3 times, most recently
from
5960f77
to
704c9fc
Compare
gumb0
force-pushed
the
capi-exec-context
branch
2 times, most recently
from
83195ad
to
86268ec
Compare
gumb0
force-pushed
the
runtime-metering
branch
3 times, most recently
from
7095691
to
a26d244
Compare
gumb0
force-pushed
the
capi-exec-context
branch
2 times, most recently
from
df42121
to
eba265e
Compare
|
Rebased. |
axic
reviewed
May 31, 2022
|
@gumb0 can you rebase? |
axic
reviewed
Jun 20, 2022
| FizzyExecutionContext* fizzy_create_execution_context(int depth) FIZZY_NOEXCEPT; | ||
|
|
||
| FizzyExecutionContext* fizzy_create_metered_execution_context( | ||
| int depth, int64_t ticks) FIZZY_NOEXCEPT; |
There was a problem hiding this comment.
Suggested change
| int depth, int64_t ticks) FIZZY_NOEXCEPT; | |
| int depth, int64_t max_ticks) FIZZY_NOEXCEPT; |
Perhaps this?
axic
reviewed
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #626.