Basic runtime metering #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
runtime-metering
branch
3 times, most recently
from
4e0e6be to
340309f
Compare
Codecov Report
@@ Coverage Diff @@
## master #626 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 88 88
Lines 13158 13184 +26
=======================================
+ Hits 13062 13088 +26
Misses 96 96
Flags with carried forward coverage won't be shown. Click here to find out more.
|
axic
reviewed
Oct 27, 2020
axic
reviewed
Oct 27, 2020
gumb0
force-pushed
the
runtime-metering
branch
from
340309f to
987b5d4
Compare
gumb0
force-pushed
the
runtime-metering
branch
7 times, most recently
from
8480da1 to
ba9f744
Compare
|
GCC 10.2 with LTO Clang 11.0.1 with LTO |
|
So that is rather curious that on clang it is faster with metering on 😅 |
gumb0
force-pushed
the
runtime-metering
branch
2 times, most recently
from
c7fd3f2 to
c333e40
Compare
axic
reviewed
Apr 16, 2021
gumb0
force-pushed
the
runtime-metering
branch
2 times, most recently
from
75d8408 to
ac50361
Compare
|
I think this looks good code wise and now the change is rather small, so it is easy to keep rebasing it. However we probably need to make our measurements without merging it, so we can easily see the overhead. (Unless it is possible to merge this with a compile-time option enabling/disabling it.) |
chfast
reviewed
Apr 20, 2021
39 tasks
|
Rebased. |
axic
reviewed
May 26, 2022
lib/fizzy/execute.cpp
Outdated
|
|
||
| ExecutionResult execute( | ||
| template <bool MeteringEnabled> | ||
| ExecutionResult execute_local_function( |
There was a problem hiding this comment.
Maybe consider specialising invoke as well so that we generate one less branch?
There was a problem hiding this comment.
Which branch? I think invoke_function does not change with MeteringEnabled... It still needs ExecutionContext to count depth.
There was a problem hiding this comment.
I think I actually meant execute and not invoke, because it is called by invoke_function.
gumb0
force-pushed
the
runtime-metering
branch
2 times, most recently
from
c65cc7a to
7095691
Compare
axic
reviewed
May 30, 2022
axic
reviewed
May 30, 2022
| @@ -444,6 +444,222 @@ constexpr uint8_t instruction_max_align_table[256] = { | |||
| /* f32_reinterpret_i32 = 0xbe */ 0, | |||
| /* f64_reinterpret_i64 = 0xbf */ 0, | |||
| }; | |||
|
|
|||
| constexpr int16_t instruction_cost_table[256] = { | |||
There was a problem hiding this comment.
What would be the way to have a user supplied cost_table?
There was a problem hiding this comment.
I guess probably passing const int16_t* to execute()
axic
approved these changes
May 30, 2022
|
chfast
approved these changes
Jun 14, 2022
axic
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method 1 of #621