Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ASan checks #590

Merged
merged 4 commits into from
Oct 7, 2020
Merged

Extend ASan checks #590

merged 4 commits into from
Oct 7, 2020

Conversation

chfast
Copy link
Collaborator

@chfast chfast commented Oct 7, 2020

Pulled from #469.

@chfast chfast force-pushed the sanitizers_config branch from eb49cf7 to 32f1e4a Compare October 7, 2020 07:22
@chfast chfast force-pushed the sanitizers_config branch from 32f1e4a to abbe6a6 Compare October 7, 2020 07:23
@chfast chfast requested review from axic and gumb0 October 7, 2020 07:39
@chfast chfast marked this pull request as ready for review October 7, 2020 07:41
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #590 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #590   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files          62       62           
  Lines        9023     9023           
=======================================
  Hits         8864     8864           
  Misses        159      159           

->Args({3, 13}) \
->Args({5, 30}) \
->Args({10, 100})
BENCHMARK_TEMPLATE(init_locals, std::vector<uint64_t>, init_locals_1)->ARGS;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just messing with ASan and/or are not useful anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@chfast chfast merged commit 34f412b into master Oct 7, 2020
@chfast chfast deleted the sanitizers_config branch October 7, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants