ci: New sanitizers config #469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
gcc_sanitizers
branch
3 times, most recently
from
3f08ab0 to
10dacc0
Compare
chfast
force-pushed
the
gcc_sanitizers
branch
from
10dacc0 to
e023d2c
Compare
chfast
force-pushed
the
gcc_sanitizers
branch
2 times, most recently
from
a74cbbc to
5bb8a96
Compare
chfast
force-pushed
the
gcc_sanitizers
branch
3 times, most recently
from
159eeea to
9575c60
Compare
Codecov Report
@@ Coverage Diff @@
## master #469 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 62 62
Lines 9023 9024 +1
=======================================
+ Hits 8864 8865 +1
Misses 159 159 |
chfast
force-pushed
the
gcc_sanitizers
branch
2 times, most recently
from
e191da5 to
4ecd2a1
Compare
gumb0
approved these changes
Oct 6, 2020
chfast
force-pushed
the
call_depth
branch
2 times, most recently
from
4730eb7 to
d2d6241
Compare
axic
reviewed
Oct 7, 2020
The "pointer-subtract" sanitizer is disabled because GCC fails to compile constexpr function with pointer subtraction. The bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97145 is to be fixed in GCC 10.3.
This reverts commit 5e1bd16.
|
This requires to lower the call depth limit to |
Merged
|
What potential issues would gcc find over clang? Can we do this limit conditionally when building for sanitizer-gcc target? |
I don't know really. They seem to have similar features, but have different bugs and versions of asan. E.g. I can enable
Please, no. I don't want to build and test different versions of Fizzy depending on debug options, sanitizer configuration, etc. |
|
512 as a call depth seems a bit on the slim side though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.