Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When accessing memory, use byte aligned accesses. #971

Merged
merged 2 commits into from
Nov 15, 2019

Conversation

nlewycky
Copy link
Contributor

Description

When accessing memory, use byte aligned accesses.

LLVM's instcombine will attempt to bump the alignment when it can prove that it's safe to do so.

Fixes #969.

Review

  • Add a short description of the the change to the CHANGELOG.md file

@nlewycky nlewycky requested a review from losfair as a code owner November 15, 2019 21:11
@nlewycky
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 15, 2019

Merge conflict

LLVM's instcombine will attempt to bump the alignment when it can prove that it's safe to do so.

Fixes #969.
@nlewycky nlewycky force-pushed the features/llvm-byte-aligned-accesses branch from 8ba3add to ecc82a7 Compare November 15, 2019 22:48
@nlewycky
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Nov 15, 2019
971: When accessing memory, use byte aligned accesses. r=nlewycky a=nlewycky

# Description
When accessing memory, use byte aligned accesses.

LLVM's instcombine will attempt to bump the alignment when it can prove that it's safe to do so.

Fixes #969.

# Review

- [ ] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: Nick Lewycky <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 15, 2019

Build succeeded

  • wasmerio.wasmer

@bors bors bot merged commit ecc82a7 into master Nov 15, 2019
@bors bors bot deleted the features/llvm-byte-aligned-accesses branch November 15, 2019 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid trap on CoreMark SIMD with LLVM backend
2 participants