Merge #971

971: When accessing memory, use byte aligned accesses. r=nlewycky a=nlewycky # Description When accessing memory, use byte aligned accesses. LLVM's instcombine will attempt to bump the alignment when it can prove that it's safe to do so. Fixes #969. # Review - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Nick Lewycky <[email protected]>
wasmerio · Nov 15, 2019 · ab59a41 · ab59a41
2 parents 182e53b + ecc82a7
commit ab59a41
Show file tree

Hide file tree

Showing 2 changed files with 142 additions and 35 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## **[Unreleased]**
 
 - [#968](https://github.com/wasmerio/wasmer/pull/968) Added `--invoke` option to the command
+- [#971](https://github.com/wasmerio/wasmer/pull/971) In LLVM backend, use unaligned loads and stores for non-atomic accesses to wasmer memory.
 - [#960](https://github.com/wasmerio/wasmer/pull/960) Fix `runtime-c-api` header files when compiled by clang.
 - [#925](https://github.com/wasmerio/wasmer/pull/925) Host functions can be closures with a captured environment.
 - [#917](https://github.com/wasmerio/wasmer/pull/917) Host functions (aka imported functions) may not have `&mut vm::Ctx` as first argument, i.e. the presence of the `&mut vm::Ctx` argument is optional.