Add probable fix of memory leak in trampoline code #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
approved these changes
Nov 4, 2019
| @@ -61,7 +61,7 @@ pub unsafe extern "C" fn wasmer_trampoline_buffer_builder_build( | |||
| #[allow(clippy::cast_ptr_alignment)] | |||
| pub unsafe extern "C" fn wasmer_trampoline_buffer_destroy(buffer: *mut wasmer_trampoline_buffer_t) { | |||
| if !buffer.is_null() { | |||
| Box::from_raw(buffer); | |||
| Box::from_raw(buffer as *mut TrampolineBuffer); | |||
There was a problem hiding this comment.
We usually use the following syntax:
let _: Box<TrampolineBuffer> = Box::from_raw(buffer);Technically, it's the same though.
However, what surprises me is: What type Box::from_raw returns in this case? Box<wasmer_trampoline_buffer>? In this case, it's size is 1, and so, yes, it leaks data.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 11, 2019
923: Add probable fix of memory leak in trampoline code r=MarkMcCaskey a=MarkMcCaskey might be what's needed for #810 ; but despite my best efforts I could not get asan working on osx, so I did not test it. By my count this accounts for 40 bytes, so there may be another issue edit: unless Rust is optimizing out turning a zero-sized type into a Box, in which case, this should account for 48 bytes Co-authored-by: Mark McCaskey <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
might be what's needed for #810 ; but despite my best efforts I could not get asan working on osx, so I did not test it.
By my count this accounts for 40 bytes, so there may be another issue
edit: unless Rust is optimizing out turning a zero-sized type into a Box, in which case, this should account for 48 bytes