Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add probable fix of memory leak in trampoline code #923

Merged
merged 1 commit into from
Nov 11, 2019
+1 −1
Merged

Add probable fix of memory leak in trampoline code #923

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/runtime-c-api/src/trampoline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ pub unsafe extern "C" fn wasmer_trampoline_buffer_builder_build(
#[allow(clippy::cast_ptr_alignment)]
pub unsafe extern "C" fn wasmer_trampoline_buffer_destroy(buffer: *mut wasmer_trampoline_buffer_t) {
if !buffer.is_null() {
Box::from_raw(buffer);
Box::from_raw(buffer as *mut TrampolineBuffer);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually use the following syntax:

let _: Box<TrampolineBuffer> = Box::from_raw(buffer);

Technically, it's the same though.

However, what surprises me is: What type Box::from_raw returns in this case? Box<wasmer_trampoline_buffer>? In this case, it's size is 1, and so, yes, it leaks data.

}
}

Expand Down