Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Move addition of brew libs to other step #5220

Merged
merged 2 commits into from
Nov 6, 2024
+4 −5
Merged

fix(ci): Move addition of brew libs to other step #5220

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85e84e9
fix(ci): Move addition of `brew` libs to other step
xdoardo Nov 5, 2024
8e43f33
fix(ci): Use specific step to install homebrew libs to apple silicon …
xdoardo Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,11 +271,6 @@ jobs:
echo "${LLVM_DIR}/bin" >> $GITHUB_PATH
env:
LLVM_DIR: .llvm
- name: Add `brew` libs to `RUSTFLAGS`
if: matrix.metadata.os == 'macos-14'
shell: bash
run: |
echo "RUSTFLAGS=-L/opt/homebrew/lib" >> $GITHUB_ENV
- name: Configure LLVM (Windows)
# The Custom Windows build does not contains llvm-config.exe, so need to setup manualy here
if: startsWith(matrix.build, 'windows-x64') && matrix.llvm_url
Expand All @@ -292,6 +287,7 @@ jobs:
# using gnu-tar is a workaround for https://github.com/actions/cache/issues/403
brew install gnu-tar
echo PATH="/usr/local/opt/gnu-tar/libexec/gnubin:$PATH" >> $GITHUB_ENV
echo "RUSTFLAGS=-L/opt/homebrew/lib" >> $GITHUB_ENV
if: startsWith(matrix.os, 'macos')
- uses: actions/cache@v2
with:
Expand Down
Loading