Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Move addition of brew libs to other step #5220

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

xdoardo
Copy link
Contributor

@xdoardo xdoardo commented Nov 5, 2024

A small patch that moves the addition of brew libs to another step.
(Reference issue: #5217)

@xdoardo xdoardo requested a review from maminrayej November 5, 2024 18:23
Copy link
Contributor

@maminrayej maminrayej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds homebrew libs for all macs (x86 and arm). Is this intended?

@xdoardo
Copy link
Contributor Author

xdoardo commented Nov 6, 2024

In short, on x86 system libraries installed by brew live in a different place than arm64, and for the former this addition should be superfluous and not damaging. Nonetheless, just to be sure, I'll move this addition to another different step.

(Note: the previous PR checked against matrix.metadata.os which does not exists!)

@maminrayej maminrayej merged commit af3dfdf into main Nov 6, 2024
71 of 73 checks passed
@maminrayej maminrayej deleted the 5217-fix-aarch64-build-issue-with-llvm branch November 6, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants