Fix append-ness of new fd affecting old fds #5162
Conversation
This commit fixes a case where opening a new file descriptor with the append flag makes previously opened non-append fds append as well. The fix is relatively simple, since the append-ness of an fd is already tracked in the virtual fs implementation, there's no need to open the actual file with the append flag. This behavior is consistent across Linux and other Wasm runtimes. fixes wasmerio#5161 Signed-off-by: Yage Hu <[email protected]>
Signed-off-by: Yage Hu <[email protected]>
@maminrayej Updated! |
There was a problem hiding this comment.
LGTM, just one question though. handle.size() (size of the file from the file's perspective) should be the same as fd_entry.inode.stat.read().unwrap().st_size (size of the file from the perspective of the inode). is there a reason you changed it? did the test fail with handle.size()?
Right. The test failed with |
|
Thanks. |
This PR fixes a case where opening a new file descriptor with the append flag makes previously opened non-append fds append as well.
The fix is relatively simple, since the append-ness of an fd is already tracked in the virtual fs implementation, there's no need to open the actual file with the append flag.
This behavior is consistent across Linux and other Wasm runtimes.
fixes #5161