Fix fd with append flag can't seek correctly #5160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an incompatible behavior (with other runtimes, and POSIX) when an fd that was opened with `fdflags::append` cannot seek to the right offset with `fd_seek`. The append flag should not "lock" the offset at the end, as it's possible to seek to another offset and read from it. Signed-off-by: Yage Hu <[email protected]>
syrusakbary
reviewed
Oct 19, 2024
Signed-off-by: Yage Hu <[email protected]>
syrusakbary
reviewed
Oct 19, 2024
maminrayej
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an incompatible behavior (with other runtimes, and POSIX) when an fd that was opened with
fdflags::appendcannot seek to the right offset withfd_seek. The append flag should not "lock" the offset at the end, as it's possible to seek to another offset and read from it.This passes all the
wasi-fyitests.fixes #5159